Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic Runtime layer to bootstrap #4387

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Add dynamic Runtime layer to bootstrap #4387

merged 3 commits into from
Jun 9, 2022

Conversation

sunjayBhatia
Copy link
Member

RuntimeCache returns only the dynamic layer if requested

Next step: add configurability

@sunjayBhatia sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label Mar 3, 2022
@sunjayBhatia sunjayBhatia added this to the 1.22.0 milestone Mar 3, 2022
@sunjayBhatia
Add dynamic Runtime layer to bootstrap
de54b99 
RuntimeCache returns only the dynamic layer if requested

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia force-pushed the rtds-dynamic-regex-size branch from 0d8f053 to de54b99 Compare March 3, 2022 20:46
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #4387 (ddf6638) into main (e2384fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head ddf6638 differs from pull request most recent head 9e84343. Consider uploading reports for the commit 9e84343 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4387      +/-   ##
==========================================
+ Coverage   76.94%   76.99%   +0.04%     
==========================================
  Files         139      140       +1     
  Lines       12750    12767      +17     
==========================================
+ Hits         9811     9830      +19     
+ Misses       2683     2681       -2     
  Partials      256      256
Impacted Files Coverage Δ
internal/envoy/v3/bootstrap.go 93.41% <100.00%> (+0.07%) ⬆️
internal/envoy/v3/runtime.go 100.00% <100.00%> (ø)
internal/xdscache/v3/runtime.go 100.00% <100.00%> (+33.33%) ⬆️

sunjayBhatia added a commit to sunjayBhatia/contour that referenced this pull request Mar 3, 2022
@sunjayBhatia
API additions for configurable Envoy Runtime fields
eb18252 
- Follow up to projectcontour#4387
- Adds Runtime section to Envoy configuration in ContourConfiguration
CRD (to be copied over to config file parameters)

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
This was referenced Mar 3, 2022
Closed
Closed
@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2022
youngnick
youngnick reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I reviewed the PR that builds on this first, this LGTM.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2022
@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022
@github-actions
Copy link

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2022
@sunjayBhatia
Merge remote-tracking branch 'origin/main' into rtds-dynamic-regex-size
e6ee1f1 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2022
@sunjayBhatia
changelog
9e84343 
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia marked this pull request as ready for review June 6, 2022 15:06
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner June 6, 2022 15:06
@sunjayBhatia sunjayBhatia requested review from tsaarni and skriss and removed request for a team June 6, 2022 15:06
@sunjayBhatia sunjayBhatia merged commit dabc796 into projectcontour:main Jun 9, 2022
@sunjayBhatia sunjayBhatia deleted the rtds-dynamic-regex-size branch June 9, 2022 15:55
This was referenced Oct 12, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick left review comments

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

Assignees
No one assigned
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sunjayBhatia @skriss @youngnick