Remove the hack in scripts for certgen job

[rajatvig]

examples/render: Set the imagePullPolicy for certen job to IfNotPresent

Set the imagePullPolicy for certen job to IfNotPresent

Fixes #4318

Signed-off-by: Rajat Vig rvig@etsy.com

[codecov]

Codecov Report

Merging #4402 (6eb0fd2) into main (584de27) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6eb0fd2 differs from pull request most recent head e332f19. Consider uploading reports for the commit e332f19 to get more accurate results

@@            Coverage Diff             @@
##             main    #4402      +/-   ##
==========================================
- Coverage   78.34%   78.33%   -0.01%     
==========================================
  Files         113      113              
  Lines       10196    10196              
==========================================
- Hits         7988     7987       -1     
- Misses       2025     2026       +1     
  Partials      183      183              

Impacted Files	Coverage Δ
internal/sorter/sorter.go	98.18% <0.00%> (-0.61%)	⬇️

[youngnick]

Nice work, thanks!

[rajatvig]

@youngnick Would you know why the build failed for release notes? Do not see any options to add release note labels.

[stevesloka]

This was set this way on the main branch because if not you'd never get an updated version of it. The versioned examples do change this to Always.

[skriss]

@stevesloka I think you're suggesting that we move this logic out of this script that generates the rendered manifests on all branches, and into https://github.com/projectcontour/contour/blob/main/hack/release/make-release-tag.sh so it only applies to rendered manifests on release branches?

[stevesloka]

I guess my point was on the main branch, if you used this code (which you really shouldn't but only in a dev/test env), then the 2nd time you updated you wouldn't get the new version of Contour since there's a version already present on the machine. =)

[skriss]

Yep makes sense -- this has been true for the contour serve, bootstrap and shutdown manager image refs for a long time so odds are nobody's actually using this manifest anyway, but filed #4404 to track the additional change