internal/envoy: Enable gzip compression for grpc-web content types. #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourquep
requested review from
tsaarni and
skriss
and removed request for
a team
sunjayBhatia
added
the
release-note/small
When Envoy serves as a `grpc-web` gateway, HTTP requests/responses use one of the [documented content-type](https://github.com/grpc/grpc-web#wire-format-mode), for which gzip compression is _not_ enabled by [default in Envoy](https://www.envoyproxy.io/docs/envoy/v1.17.4/api-v2/config/filter/http/compressor/v2/compressor.proto#envoy-api-msg-config-filter-http-compressor-v2-compressor). This MR adds the `grpc-web` content types to Envoy's default ones, so they are gzip-compressed by default. Fixes #4345 Signed-off-by: Pascal Bourque <pascal@studyo.co>
Signed-off-by: Pascal Bourque <pascal@studyo.co>
Codecov Report
@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
- Coverage 78.34% 73.68% -4.66%
==========================================
Files 113 137 +24
Lines 10196 12340 +2144
==========================================
+ Hits 7988 9093 +1105
- Misses 2025 3049 +1024
- Partials 183 198 +15
|
|
Marking this PR stale since there has been no activity for 14 days. It will be closed if there is no activity for another 30 days. |
github-actions
bot
added
the
lifecycle/stale
sunjayBhatia
removed
the
lifecycle/stale
|
@projectcontour/maintainers, anyone else want to review this, before I hit merge? |
sunjayBhatia
reviewed
Apr 6, 2022
Good point. I had based my PR on this document, from the readme of the grpc-web JS runtime. But indeed, all the formats defined in the grpc-web spec should probably be included. I will update the PR soon. |
As defined in the official grpc-web spec https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-WEB.md#protocol-differences-vs-grpc-over-http2 Signed-off-by: Pascal Bourque <pascal@studyo.co>
|
@youngnick When can you merge and release this PR? |
sunjayBhatia
approved these changes
Apr 14, 2022
sunjayBhatia
added a commit
to sunjayBhatia/contour
that referenced
this pull request
Apr 15, 2022
Follow up to projectcontour#4403 which started using a deprecated field Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added a commit
that referenced
this pull request
Apr 18, 2022
Follow up to #4403 which started using a deprecated field Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Envoy serves as a
grpc-webgateway, HTTP requests/responses use one of the documented content-type, for which gzip compression is not enabled by default in Envoy.This MR adds the
grpc-webcontent types to Envoy's default ones, so they are gzip-compressed by default.Fixes #4345
Signed-off-by: Pascal Bourque pascal@studyo.co