internal/provisioner: support more than one instance per namespace #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4426 +/- ##
==========================================
+ Coverage 74.20% 74.26% +0.06%
==========================================
Files 136 137 +1
Lines 12237 12272 +35
==========================================
+ Hits 9080 9114 +34
- Misses 2959 2960 +1
Partials 198 198
|
skriss
added
the
release-note/minor
skriss
force-pushed
the
pr-gw-mult-per-ns
branch
from
4db2114 to
40097c3
Compare
skriss
commented
Mar 29, 2022
Comment on lines
+51
to
+59
| // ContourCertsSecretName returns the name of the Contour xDS TLS certs Secret resource. | ||
| func (c *Contour) ContourCertsSecretName() string { | ||
| return c.Name + "-contourcert" | ||
| } | ||
|
|
||
| // EnvoyCertsSecretName returns the name of the Envoy xDS TLS certs Secret resource. | ||
| func (c *Contour) EnvoyCertsSecretName() string { | ||
| return c.Name + "-envoycert" | ||
| } |
There was a problem hiding this comment.
I have a subsequent PR that flips these cert secrets' names around to use the Gateway name as a suffix rather than a prefix, for consistency. Will be done as part of directly generating the certs rather than using the Job.
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
pr-gw-mult-per-ns
branch
from
40097c3 to
b06fc00
Compare
skriss
requested review from
tsaarni and
stevesloka
and removed request for
a team
|
Rebased. |
sunjayBhatia
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for provisioning more than one Contour+Envoy instance per namespace.
Closes #4418.