-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Each path in an Ingress is required to have a corresponding path type. #4446
Conversation
d2558b2
to
7396386
Compare
Codecov Report
@@ Coverage Diff @@
## main #4446 +/- ##
==========================================
- Coverage 74.12% 74.10% -0.02%
==========================================
Files 137 137
Lines 12219 12219
==========================================
- Hits 9057 9055 -2
- Misses 2964 2966 +2
Partials 198 198
|
Thanks for this change @lou-lan, could you add a changelog in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM once the CI checks are passing, thanks @lou-lan!
7396386
to
12daad8
Compare
I've updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs these same changes propagated to the main
version directory of the docs as well so that future release versions contain this change
12daad8
to
2118a37
Compare
I've updated the docs in the |
…orresponding path type. Signed-off-by: lou-lan <loulan@loulan.me>
2118a37
to
02beedc
Compare
Each path in an Ingress is required to have a corresponding path type. Paths that do not include an explicit pathType will fail validation.
Fix #4447