Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each path in an Ingress is required to have a corresponding path type. #4446

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

lou-lan
Copy link
Contributor

@lou-lan lou-lan commented Apr 3, 2022

Each path in an Ingress is required to have a corresponding path type. Paths that do not include an explicit pathType will fail validation.

Fix #4447

@lou-lan lou-lan requested a review from a team as a code owner April 3, 2022 05:29
@lou-lan lou-lan requested review from tsaarni and skriss and removed request for a team April 3, 2022 05:29
@lou-lan lou-lan force-pushed the fix/ingress-path-type branch from d2558b2 to 7396386 Compare April 3, 2022 05:31
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #4446 (45d0e5d) into main (6112181) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 45d0e5d differs from pull request most recent head 02beedc. Consider uploading reports for the commit 02beedc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4446      +/-   ##
==========================================
- Coverage   74.12%   74.10%   -0.02%     
==========================================
  Files         137      137              
  Lines       12219    12219              
==========================================
- Hits         9057     9055       -2     
- Misses       2964     2966       +2     
  Partials      198      198              
Impacted Files Coverage Δ
internal/sorter/sorter.go 97.57% <0.00%> (-1.22%) ⬇️

@youngnick youngnick added the release-note/docs A documentation change for the release notes. label Apr 4, 2022
@youngnick
Copy link
Member

Thanks for this change @lou-lan, could you add a changelog in changelogs/unreleased, using docs-sample.md as a template? It just needs to be a one-line description of the change. I've already set the label for you, so that should clear the failing CI checks.

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM once the CI checks are passing, thanks @lou-lan!

@lou-lan lou-lan force-pushed the fix/ingress-path-type branch from 7396386 to 12daad8 Compare April 4, 2022 08:15
@lou-lan
Copy link
Contributor Author

lou-lan commented Apr 4, 2022

This LGTM once the CI checks are passing, thanks @lou-lan!

I've updated it.

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs these same changes propagated to the main version directory of the docs as well so that future release versions contain this change

@lou-lan lou-lan force-pushed the fix/ingress-path-type branch from 12daad8 to 2118a37 Compare April 4, 2022 13:55
@lou-lan
Copy link
Contributor Author

lou-lan commented Apr 4, 2022

I think this needs these same changes propagated to the main version directory of the docs as well so that future release versions contain this change

I've updated the docs in the main version directory.

@lou-lan lou-lan requested a review from sunjayBhatia April 4, 2022 13:59
…orresponding path type.

Signed-off-by: lou-lan <loulan@loulan.me>
@lou-lan lou-lan force-pushed the fix/ingress-path-type branch from 2118a37 to 02beedc Compare April 4, 2022 14:17
@skriss skriss merged commit 6add750 into projectcontour:main Apr 4, 2022
@lou-lan lou-lan deleted the fix/ingress-path-type branch April 5, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: Ingress API - Paths that do not include an explicit pathType will fail validation.
4 participants