internal/provisioner: support using ContourDeployment.Config #4459
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
- Coverage 76.47% 76.47% -0.01%
==========================================
Files 138 138
Lines 12427 12433 +6
==========================================
+ Hits 9504 9508 +4
- Misses 2674 2676 +2
Partials 249 249
|
skriss
added
the
release-note/small
skriss
force-pushed
the
gw-class-params-contourconfig
branch
from
1e7441c to
5f756e4
Compare
When a GatewayClass has a parametersRef to a ContourDeployment resource that has Config specified, use that Config when provisioning Gateways and their associated ContourConfigurations. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
gw-class-params-contourconfig
branch
from
01e38b1 to
3c3be71
Compare
skriss
requested review from
tsaarni,
youngnick and
sunjayBhatia
and removed request for
a team
| @@ -323,3 +332,22 @@ func (r *gatewayReconciler) ensureContourDeleted(ctx context.Context, contour *m | |||
|
|
|||
| return errs | |||
| } | |||
|
|
|||
| func (r *gatewayReconciler) getGatewayClassParams(ctx context.Context, gatewayClass *gatewayapi_v1alpha2.GatewayClass) (*contour_api_v1alpha1.ContourDeployment, error) { | |||
| if !isContourDeploymentRef(gatewayClass.Spec.ParametersRef) { | |||
There was a problem hiding this comment.
is this case possible? since GatewayClasses won't be accepted if they have an invalid parametersref and we won't reconcile a Gateway for a GatewayClass that has not been accepted?
There was a problem hiding this comment.
Yeah probably not, I think this function call is effectively just handling nil-checking on the parametersref right now (since parameters are optional). Can simplify to just do that directly.
There was a problem hiding this comment.
Thinking about it some more, there probably is a (admittedly pretty hard-to-trigger) race condition here, if a GatewayClass has been updated from a valid ContourDeployment ref to a ref to some other resource type but hasn't yet reconciled / marked "Accepted: false", and ~simultaneously a Gateway reconcile is triggered that uses that GatewayClass. Based on that I'm thinking it's safer to keep the check here (it's just checking fields, no cache/API calls so not expensive to execute), but I'll add some comments.
There was a problem hiding this comment.
ah yep that is a good point about the race, yeah worth adding some comments (and maybe a test if possible) as to what is expected in this edge case
Signed-off-by: Steve Kriss <krisss@vmware.com>
When a GatewayClass has a parametersRef
to a ContourDeployment resource that has
Config specified, use that Config when
provisioning Gateways and their associated
ContourConfigurations.
Signed-off-by: Steve Kriss krisss@vmware.com