Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default controller name to projectcontour.io/gateway-controller #4474

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Apr 15, 2022

This more general controller name makes sense
given that the provisioner is just one piece
of Gateway control logic; the xDS server also
plays a major role.

Signed-off-by: Steve Kriss krisss@vmware.com

This more general controller name makes sense
given that the provisioner is just one piece
of Gateway control logic; the xDS server also
plays a major role.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner April 15, 2022 17:47
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team April 15, 2022 17:47
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Apr 15, 2022
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from sunjayBhatia April 15, 2022 17:49
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #4474 (64c9de6) into main (ec23ef7) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 64c9de6 differs from pull request most recent head 6b564a9. Consider uploading reports for the commit 6b564a9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4474   +/-   ##
=======================================
  Coverage   76.65%   76.65%           
=======================================
  Files         139      139           
  Lines       12490    12490           
=======================================
  Hits         9574     9574           
  Misses       2669     2669           
  Partials      247      247           
Impacted Files Coverage Δ
cmd/contour/gatewayprovisioner.go 0.00% <0.00%> (ø)

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i like that name change

@skriss skriss merged commit 8a6e391 into projectcontour:main Apr 15, 2022
@skriss skriss deleted the change-controller-string branch April 15, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants