internal/dag: use RefNotPermitted reason when applicable #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
requested review from
tsaarni,
youngnick and
sunjayBhatia
and removed request for
a team
skriss
added
the
release-note/small
sunjayBhatia
approved these changes
Apr 18, 2022
When an HTTPRoute or TLSRoute has a cross-namespace backend ref that's not permitted by a ReferencePolicy, use the RefNotPermitted condition reason. Closes projectcontour#4479. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
route-refnotpermitted
branch
from
9446577 to
ac79f75
Compare
Codecov Report
@@ Coverage Diff @@
## main #4482 +/- ##
==========================================
+ Coverage 76.65% 76.67% +0.01%
==========================================
Files 139 139
Lines 12490 12500 +10
==========================================
+ Hits 9574 9584 +10
Misses 2669 2669
Partials 247 247
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an HTTPRoute or TLSRoute has a cross-namespace
backend ref that's not permitted by a ReferencePolicy,
use the RefNotPermitted condition reason.
Closes #4479.
Signed-off-by: Steve Kriss krisss@vmware.com
ref. kubernetes-sigs/gateway-api#1081 (comment)