internal/envoy: use typed config for all extensions #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses typed config for all extensions to remove reliance on well-known names or internal type URL constants. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
tsaarni,
stevesloka,
sunjayBhatia and
youngnick
and removed request for
a team,
tsaarni and
stevesloka
skriss
added
the
release-note/small
Merged
Codecov Report
@@ Coverage Diff @@
## main #4487 +/- ##
==========================================
+ Coverage 76.73% 76.76% +0.02%
==========================================
Files 139 139
Lines 12678 12681 +3
==========================================
+ Hits 9729 9735 +6
+ Misses 2696 2693 -3
Partials 253 253
|
sunjayBhatia
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses typed config for all extensions to remove
reliance on well-known names or internal type
URL constants.
Signed-off-by: Steve Kriss krisss@vmware.com
(This is needed in order to upgrade to Envoy 1.22 since we still have a few spots that are relying on well-known names, support for which is being dropped in 1.22).