Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: remove ContourConfiguration DebugLogLevel and KubernetesDebugLogLevel #4534

Merged
merged 3 commits into from
May 20, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented May 17, 2022

Removes these two fields from the ContourConfiguration
spec as they were unused since they are required to be
specified via CLI flag.

Signed-off-by: Steve Kriss krisss@vmware.com

…gLevel

Removes these two fields from the ContourConfiguration
spec as they were unused since they are required to be
specified via CLI flag.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner May 17, 2022 15:14
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team May 17, 2022 15:14
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label May 17, 2022
@skriss skriss requested a review from sunjayBhatia May 17, 2022 15:15
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like one more removal needed in the e2e tests otherwise lgtm

Signed-off-by: Steve Kriss <krisss@vmware.com>
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #4534 (2373bff) into main (dea24e8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2373bff differs from pull request most recent head 19d12ec. Consider uploading reports for the commit 19d12ec to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4534      +/-   ##
==========================================
- Coverage   76.88%   76.86%   -0.02%     
==========================================
  Files         139      139              
  Lines       12756    12746      -10     
==========================================
- Hits         9807     9797      -10     
  Misses       2695     2695              
  Partials      254      254              
Impacted Files Coverage Δ
cmd/contour/servecontext.go 82.99% <100.00%> (+0.21%) ⬆️
internal/contourconfig/contourconfiguration.go 97.41% <100.00%> (-1.31%) ⬇️

@skriss skriss merged commit 4c3b50f into projectcontour:main May 20, 2022
@skriss skriss deleted the pr-rm-contourconfig-log-fields branch May 23, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants