Gateway API: allow wildcard hostnames to match more than one DNS label #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Gateway API hostname logic to allow wildcard hostnames to match more than one DNS label per clarification in the upstream spec. Closes projectcontour#4554. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
tsaarni and
youngnick
and removed request for
a team
skriss
added
the
release-note/small
Codecov Report
@@ Coverage Diff @@
## main #4559 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 139 139
Lines 12751 12750 -1
=======================================
Hits 9811 9811
+ Misses 2684 2683 -1
Partials 256 256
|
sunjayBhatia
reviewed
Jun 6, 2022
sunjayBhatia
reviewed
Jun 6, 2022
Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Gateway API hostname logic to allow
wildcard hostnames to match more than one
DNS label per clarification in the upstream
spec.
Closes #4554.
Signed-off-by: Steve Kriss krisss@vmware.com