internal/provisioner: Use local variable to replace the long access chain of fields #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
izturn
requested review from
skriss and
sunjayBhatia
and removed request for
a team
youngnick
reviewed
Jun 21, 2022
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
Codecov Report
@@ Coverage Diff @@
## main #4586 +/- ##
==========================================
+ Coverage 76.82% 76.84% +0.01%
==========================================
Files 140 140
Lines 12813 12818 +5
==========================================
+ Hits 9844 9850 +6
+ Misses 2712 2711 -1
Partials 257 257
|
|
thx @youngnick done, but how can i set the release note label? |
tsaarni
added
the
release-note/minor
tsaarni
reviewed
Jun 21, 2022
youngnick
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems the fields of object nest too deeply, so use a local variable to replace it to make read code easy
Signed-off-by: Gang Liu gang.liu@daocloud.io