Gateway API: only keep first match for a given header name #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic to only keep the first HTTP header match with a given name (case-insensitive) for each HTTP route rule, per the Gateway API spec. Closes projectcontour#4591. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added
the
release-note/small
skriss
requested review from
tsaarni and
youngnick
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #4593 +/- ##
=======================================
Coverage 76.85% 76.86%
=======================================
Files 140 140
Lines 12864 12867 +3
=======================================
+ Hits 9887 9890 +3
Misses 2720 2720
Partials 257 257
|
sunjayBhatia
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to only keep the first HTTP header match
with a given name (case-insensitive) for each HTTP
route rule, per the Gateway API spec.
Closes #4591.
Signed-off-by: Steve Kriss krisss@vmware.com