internal/dag: set Listener condition for invalid namespace selector #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the logic for parsing/validating a Listener namespace label selector into computeListener, and sets Listener conditions appropriately when the selector is invalid. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
stevesloka and
youngnick
and removed request for
a team
skriss
added
the
release-note/small
Signed-off-by: Steve Kriss <krisss@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4615 +/- ##
==========================================
- Coverage 77.03% 76.08% -0.95%
==========================================
Files 140 140
Lines 13036 13223 +187
==========================================
+ Hits 10042 10061 +19
- Misses 2734 2904 +170
+ Partials 260 258 -2
|
sunjayBhatia
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic for parsing/validating a Listener
namespace label selector into computeListener, and
sets Listener conditions appropriately when the
selector is invalid.
Signed-off-by: Steve Kriss krisss@vmware.com