Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new access log operators from Envoy 1.23.0 #4627

Merged

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Jul 19, 2022

See https://www.envoyproxy.io/docs/envoy/v1.23.0/version_history/v1.23/v1.23.0#new-features

Adds support for %METADATA% complex operator (not %UPSTREAM_METADATA% since
that is deprecated apparently) and simple operators:
%UPSTREAM_PROTOCOL%, %UPSTREAM_PEER_SUBJECT%, %UPSTREAM_PEER_ISSUER%,
%UPSTREAM_TLS_SESSION_ID%, %UPSTREAM_TLS_CIPHER%,
%UPSTREAM_TLS_VERSION%, %UPSTREAM_PEER_CERT_V_START%,
%UPSTREAM_PEER_CERT_V_END%, %UPSTREAM_PEER_CERT% and
%UPSTREAM_FILTER_STATE%

Fixes #4624

@sunjayBhatia sunjayBhatia added this to the 1.22.0 milestone Jul 19, 2022
@sunjayBhatia sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #4627 (b010d9f) into main (93c0cee) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b010d9f differs from pull request most recent head a80fba8. Consider uploading reports for the commit a80fba8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4627      +/-   ##
==========================================
- Coverage   75.96%   75.94%   -0.02%     
==========================================
  Files         140      140              
  Lines       13091    13091              
==========================================
- Hits         9944     9942       -2     
- Misses       2891     2893       +2     
  Partials      256      256              
Impacted Files Coverage Δ
internal/sorter/sorter.go 97.59% <0.00%> (-1.21%) ⬇️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a changelog

See
https://www.envoyproxy.io/docs/envoy/v1.23.0/version_history/v1.23/v1.23.0#new-features

Adds support for %METADATA% complex operator (not %UPSTREAM_METADATA% since
that is deprecated apparently) and simple operators:
%UPSTREAM_PROTOCOL%, %UPSTREAM_PEER_SUBJECT%, %UPSTREAM_PEER_ISSUER%,
%UPSTREAM_TLS_SESSION_ID%, %UPSTREAM_TLS_CIPHER%,
%UPSTREAM_TLS_VERSION%, %UPSTREAM_PEER_CERT_V_START%,
%UPSTREAM_PEER_CERT_V_END%, %UPSTREAM_PEER_CERT% and
%UPSTREAM_FILTER_STATE%

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia force-pushed the envoy-1.23.0-accesslog-operators branch from 05ff872 to a80fba8 Compare July 20, 2022 14:38
@sunjayBhatia sunjayBhatia marked this pull request as ready for review July 20, 2022 14:38
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner July 20, 2022 14:38
@sunjayBhatia sunjayBhatia requested review from skriss and youngnick and removed request for a team July 20, 2022 14:38
@sunjayBhatia sunjayBhatia merged commit f7b8889 into projectcontour:main Jul 20, 2022
@sunjayBhatia sunjayBhatia deleted the envoy-1.23.0-accesslog-operators branch July 20, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Envoy 1.23.0 access log operators
2 participants