Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crd/ContourDeployment: Add fields for (update)Strategy #4713

Merged
merged 22 commits into from
Nov 28, 2022
Merged

crd/ContourDeployment: Add fields for (update)Strategy #4713

merged 22 commits into from
Nov 28, 2022

Conversation

izturn
Copy link
Member

@izturn izturn commented Sep 11, 2022

add the fields to crd/ContourDeployment to enable (update)Strategy for Contour components

Signed-off-by: Gang Liu gang.liu@daocloud.io

@izturn
add field: updateStrategy/strategy for envoy & contour to crd/Contour…
362ac31 
…Deployment

Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn izturn requested a review from a team as a code owner September 11, 2022 09:24
@izturn izturn requested review from tsaarni and skriss and removed request for a team September 11, 2022 09:24
@izturn
add changelog
95065dd 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@codecov
Copy link

codecov bot commented Sep 11, 2022 •
edited
Loading

Codecov Report

Merging #4713 (e0b0c12) into main (ccb79f8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4713      +/-   ##
==========================================
+ Coverage   75.95%   75.99%   +0.03%     
==========================================
  Files         139      139              
  Lines       16855    16878      +23     
==========================================
+ Hits        12803    12826      +23     
  Misses       3798     3798              
  Partials      254      254
Impacted Files Coverage Δ
internal/provisioner/controller/gateway.go 59.48% <100.00%> (+2.78%) ⬆️
internal/provisioner/model/model.go 93.87% <100.00%> (+1.47%) ⬆️
...nternal/provisioner/objects/dataplane/dataplane.go 85.33% <100.00%> (-0.36%) ⬇️
...ernal/provisioner/objects/deployment/deployment.go 89.49% <100.00%> (-0.29%) ⬇️

@izturn
add changelog
155f1af 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
update yaml
f9d2a3f 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@sunjayBhatia sunjayBhatia mentioned this pull request Sep 15, 2022
Closed
7 tasks
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied - After 30d of inactivity since lifecycle/stale was applied, the PR is closed
    You can:
  • Mark this PR as fresh by commenting or pushing a commit - Close this PR - Offer to help out with triage
    Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2022
@sunjayBhatia sunjayBhatia added release-note/small A small change that needs one line of explanation in the release notes. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2022
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2022
@izturn
Copy link
Member Author

izturn commented Oct 14, 2022

any advise?

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2022
@izturn
Copy link
Member Author

izturn commented Oct 18, 2022

@skriss let's move on with this one ?

@izturn
merge & fix conflict
324e645 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
Copy link
Member Author

izturn commented Oct 24, 2022

ping @sunjayBhatia @skriss

izturn added 3 commits October 31, 2022 13:07
@izturn
Merge remote-tracking branch 'upstream/main' into feat/update-strategy
feb1f36
@izturn
split ContourDeployment & add ut
9250a0d 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
split ContourDeployment & add ut
e34c1df 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn izturn requested review from skriss and removed request for tsaarni October 31, 2022 07:11
izturn added 2 commits October 31, 2022 17:11
@izturn
make golint happy
efc0f1d 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
merge & fix conflict
c72ecec 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
Copy link
Member Author

izturn commented Nov 3, 2022

@skriss ping

@izturn
Copy link
Member Author

izturn commented Nov 7, 2022 •
edited
Loading

@skriss BTW, lint & codegen, are all happy in my local dev, what can I do?

@izturn izturn requested a review from skriss November 7, 2022 02:38
@skriss
Copy link
Member

skriss commented Nov 7, 2022

@skriss BTW, lint & codegen, are all happy in my local dev, what can I do?

Looks like you need to merge or rebase on main, there are some conflicts from the PR to move to generics within the provisioner package.

skriss
skriss requested changes Nov 7, 2022
View reviewed changes
changelogs/unreleased/4713-izturn-deprecation.md Outdated Show resolved Hide resolved
changelogs/unreleased/4713-izturn-deprecation.md Outdated Show resolved Hide resolved
changelogs/unreleased/4713-izturn-deprecation.md Outdated Show resolved Hide resolved
sunjayBhatia
sunjayBhatia reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some things to clean up in implementation etc. but the API change looks good to me 👍🏽

@izturn izturn requested a review from skriss November 8, 2022 01:46
@izturn
make check happy
30b5836 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
Copy link
Member Author

izturn commented Nov 8, 2022

@skriss BTW, lint & codegen, are all happy in my local dev, what can I do?

Looks like you need to merge or rebase on main, there are some conflicts from the PR to move to generics within the provisioner package.

I had merged on main, but the codegen had not passed too

@skriss
Copy link
Member

skriss commented Nov 9, 2022

Looks like you have a local file examples/gateway/01-admission_webhook_local.yaml that is getting pulled in, you'll need to remove that before running make generate.

@izturn
make generate
1890466 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
Copy link
Member Author

izturn commented Nov 10, 2022

thx, it's my fault

@izturn
Copy link
Member Author

izturn commented Nov 14, 2022

ping @skriss @sunjayBhatia

@izturn
little refactor
5b91fb9 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn izturn requested review from sunjayBhatia and removed request for skriss November 16, 2022 01:55
@izturn
Copy link
Member Author

izturn commented Nov 17, 2022

@sunjayBhatia PTAL

skriss
skriss approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave for @sunjayBhatia

sunjayBhatia
sunjayBhatia reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but re-running CI to see if failure was a flake or not (since it was in the provisioner suite)

@izturn
Copy link
Member Author

izturn commented Nov 18, 2022

lgtm, but re-running CI to see if failure was a flake or not (since it was in the provisioner suite)

I don't know why, the last test, the HTTP code is 404, but this time it's 503 :(

@izturn izturn requested a review from sunjayBhatia November 18, 2022 02:37
@izturn
Copy link
Member Author

izturn commented Nov 25, 2022

ping

@skriss skriss merged commit 632808c into projectcontour:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

Assignees
No one assigned
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izturn @skriss @sunjayBhatia