HTTPProxy: add healthCheck port config #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
…contour into health-check-port � Conflicts: � apis/projectcontour/v1/httpproxy.go � examples/contour/01-crds.yaml � examples/render/contour-deployment.yaml � examples/render/contour-gateway-provisioner.yaml � examples/render/contour-gateway.yaml � examples/render/contour.yaml � site/content/docs/main/config/api-reference.html
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
requested review from
tsaarni and
skriss
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4761 +/- ##
==========================================
+ Coverage 76.07% 76.12% +0.04%
==========================================
Files 140 140
Lines 16880 16953 +73
==========================================
+ Hits 12842 12906 +64
- Misses 3786 3790 +4
- Partials 252 257 +5
|
Signed-off-by: yy <yang.yang@daocloud.io>
sunjayBhatia
added
the
release-note/minor
sunjayBhatia
reviewed
Oct 4, 2022
sunjayBhatia
reviewed
Oct 4, 2022
sunjayBhatia
reviewed
Oct 4, 2022
skriss
requested changes
Oct 5, 2022
There was a problem hiding this comment.
Thanks for the PR @yangyy93!
Please also add some documentation to https://github.com/projectcontour/contour/blob/main/site/content/docs/main/config/health-checks.md on this new feature.
|
@yangyy93 just checking in to see if you'll be able to address the code review feedback above, thanks! |
Signed-off-by: yy <yang.yang@daocloud.io>
Signed-off-by: yy <yang.yang@daocloud.io>
|
Thank you for your comments, the relevant documents and comments have been revised. |
Signed-off-by: yy <yang.yang@daocloud.io>
skriss
approved these changes
Oct 19, 2022
sunjayBhatia
requested changes
Oct 19, 2022
Signed-off-by: yy <yang.yang@daocloud.io>
do you have any other suggestions？ @sunjayBhatia |
|
@sunjayBhatia I think this one's just awaiting another look from you |
sunjayBhatia
approved these changes
Oct 28, 2022
sunjayBhatia
added a commit
to sunjayBhatia/contour
that referenced
this pull request
Oct 28, 2022
Follow up to projectcontour#4761 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
|
follow up: #4828 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add healthCheck port for httproute and tcproute
fix #4655
Signed-off-by: yy [yang.yang@daocloud.io]