Add support for optional certificate validation #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierdelorme
requested review from
tsaarni and
stevesloka
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4796 +/- ##
==========================================
- Coverage 76.09% 76.09% -0.01%
==========================================
Files 140 140
Lines 16895 16896 +1
==========================================
Hits 12857 12857
- Misses 3786 3787 +1
Partials 252 252
|
gautierdelorme
force-pushed
the
optional_mtls
branch
from
9fe25e9 to
2588e2a
Compare
sunjayBhatia
added
the
release-note/minor
|
Do you think this change could make it to the 1.23 release? |
tsaarni
reviewed
Oct 20, 2022
Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
gautierdelorme
force-pushed
the
optional_mtls
branch
from
2588e2a to
0f03cb1
Compare
skriss
requested changes
Oct 20, 2022
There was a problem hiding this comment.
@gautierdelorme nice work, everything looks great to me, just one minor wording suggestion on the changelog. Thanks for the PR!
gautierdelorme
force-pushed
the
optional_mtls
branch
from
d910de6 to
e9efdcb
Compare
Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
gautierdelorme
force-pushed
the
optional_mtls
branch
from
e9efdcb to
45a2250
Compare
skriss
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
LGTM pending CI, will leave for a second maintainer to approve though. Thanks again @gautierdelorme!
tsaarni
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
Great to have this feature, thank you for contributing this @gautierdelorme!
moeyui1
pushed a commit
to moeyui1/contour
that referenced
this pull request
Oct 26, 2022
* Add support for optional certificate validation Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to support optional mTLS so that apps can use different authentication schemes (e.g. mTLS, cookies, tokens, etc...).
I initially named the new option
OnlyVerifyClientCertIfGivenbut this was confusing whenSkipClientCertValidationis also enabled. I decided to go withOnlyRequestClientCert(and notRequireClientCertfor example) since all the other option are opt-in by setting them to true so I would like to avoid changing this assumption with this new option. The other problem was at the Go API levelDownstreamValidation.RequireClientCertdefault value would befalsesince that's the null value for booleans which would change the current behavior and I wanted to avoid implementing it as a pointer.Signed-off-by: Gautier Delorme gautier.delorme@gmail.com