Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow TLS secrets to be of type Opaque #4799

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Oct 17, 2022

Closes #3180.

Signed-off-by: Steve Kriss krisss@vmware.com

@skriss skriss added this to the 1.24.0 milestone Oct 17, 2022
@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #4799 (54adb2d) into main (ec00824) will decrease coverage by 0.04%.
The diff coverage is 89.65%.

❗ Current head 54adb2d differs from pull request most recent head e008ac5. Consider uploading reports for the commit e008ac5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4799      +/-   ##
==========================================
- Coverage   76.16%   76.11%   -0.05%     
==========================================
  Files         140      140              
  Lines       16914    16887      -27     
==========================================
- Hits        12882    12854      -28     
- Misses       3780     3783       +3     
+ Partials      252      250       -2     
Impacted Files Coverage Δ
internal/dag/dag.go 96.62% <ø> (ø)
internal/dag/cache.go 92.39% <85.00%> (+0.90%) ⬆️
internal/dag/secret.go 74.00% <92.10%> (-0.40%) ⬇️
internal/dag/extension_processor.go 95.79% <100.00%> (ø)
internal/dag/gatewayapi_processor.go 94.72% <100.00%> (ø)
internal/dag/httpproxy_processor.go 93.14% <100.00%> (-0.07%) ⬇️
internal/dag/ingress_processor.go 97.07% <100.00%> (ø)
internal/protobuf/helpers.go 76.47% <0.00%> (-16.39%) ⬇️
internal/sorter/sorter.go 98.46% <0.00%> (-0.52%) ⬇️
internal/provisioner/controller/gateway.go 56.22% <0.00%> (-0.47%) ⬇️
... and 18 more

Closes projectcontour#3180.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss force-pushed the pr-allow-opaque-tls-secret branch from 54adb2d to e008ac5 Compare October 21, 2022 16:39
@skriss skriss marked this pull request as ready for review October 21, 2022 16:39
@skriss skriss requested a review from a team as a code owner October 21, 2022 16:39
@skriss skriss requested review from tsaarni, stevesloka and sunjayBhatia and removed request for a team October 21, 2022 16:39
@skriss skriss merged commit f4778a5 into projectcontour:main Oct 24, 2022
@skriss skriss deleted the pr-allow-opaque-tls-secret branch October 24, 2022 17:10
moeyui1 pushed a commit to moeyui1/contour that referenced this pull request Oct 26, 2022
Closes projectcontour#3180.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Contour to work with Opaque secret as long as it contains tls.crt and tls.key
2 participants