crd/ContourDeployment: Add field for set externalTrafficPolicy for service/envoy #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
izturn
requested review from
tsaarni and
stevesloka
and removed request for
a team
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
7 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4803 +/- ##
==========================================
+ Coverage 76.12% 76.15% +0.03%
==========================================
Files 139 139
Lines 16918 16928 +10
==========================================
+ Hits 12879 12892 +13
+ Misses 3784 3781 -3
Partials 255 255
|
skriss
added
the
release-note/small
skriss
requested changes
Oct 24, 2022
izturn
requested review from
skriss
and removed request for
tsaarni and
stevesloka
skriss
requested changes
Oct 31, 2022
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
skriss
approved these changes
Nov 1, 2022
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
sunjayBhatia
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the field to
crd/ContourDeploymentto support changingService/Envoy's ExternalTrafficPolicySigned-off-by: Gang Liu gang.liu@daocloud.io