Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates for "FIPS 140-2 in Contour" #4813

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

moeyui1
Copy link
Contributor

@moeyui1 moeyui1 commented Oct 21, 2022

Some updates for FIPS 140-2 in Contour, see also #4794 :

  1. Add description for Go 1.19+ to enable integrating BoringCrypto;
  2. Add rsc.io/goversion as an another way to validate whether the contour binary has been compiled with BoringCrypto.

Closes #4794.

@moeyui1 moeyui1 requested a review from a team as a code owner October 21, 2022 07:43
@moeyui1 moeyui1 requested review from tsaarni and skriss and removed request for a team October 21, 2022 07:43
@sunjayBhatia sunjayBhatia added the release-note/docs A documentation change for the release notes. label Oct 25, 2022
@sunjayBhatia sunjayBhatia self-requested a review October 25, 2022 14:55
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #4813 (d9bb096) into main (a256481) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4813      +/-   ##
==========================================
- Coverage   76.09%   75.95%   -0.14%     
==========================================
  Files         140      139       -1     
  Lines       16895    16855      -40     
==========================================
- Hits        12857    12803      -54     
- Misses       3786     3798      +12     
- Partials      252      254       +2     
Impacted Files Coverage Δ
...ner/objects/rbac/serviceaccount/service_account.go 53.57% <0.00%> (-10.54%) ⬇️
internal/envoy/bootstrap.go 52.27% <0.00%> (-5.23%) ⬇️
internal/provisioner/objects/service/service.go 73.09% <0.00%> (-4.64%) ⬇️
internal/provisioner/objects/rbac/role/role.go 69.04% <0.00%> (-4.54%) ⬇️
...ovisioner/objects/rbac/rolebinding/role_binding.go 70.73% <0.00%> (-3.78%) ⬇️
...ts/rbac/clusterrolebinding/cluster_role_binding.go 70.73% <0.00%> (-3.78%) ⬇️
...nternal/provisioner/objects/dataplane/dataplane.go 85.68% <0.00%> (-2.20%) ⬇️
...ovisioner/objects/rbac/clusterrole/cluster_role.go 78.94% <0.00%> (-1.65%) ⬇️
...ernal/provisioner/objects/deployment/deployment.go 89.77% <0.00%> (-1.57%) ⬇️
internal/dag/httpproxy_processor.go 92.74% <0.00%> (-0.40%) ⬇️
... and 28 more

Fixes projectcontour#4794.

Signed-off-by: moeyui1 <894immyk@gmail.com>
skriss
skriss previously requested changes Oct 31, 2022
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moeyui1 for the updates here! One comment from me. cc @sunjayBhatia

site/content/guides/fips.md Outdated Show resolved Hide resolved
@sunjayBhatia
Copy link
Member

thanks for the PR @moeyui1, running through the update instructions now 👍🏽

@moeyui1
Copy link
Contributor Author

moeyui1 commented Nov 8, 2022

A little busy these days, will complete this a few days later.

@moeyui1 moeyui1 force-pushed the main branch 2 times, most recently from ae89695 to 0c16d58 Compare November 16, 2022 13:57
@moeyui1 moeyui1 requested review from skriss and removed request for tsaarni November 16, 2022 13:59
site/content/guides/fips.md Outdated Show resolved Hide resolved
…MENT

Signed-off-by: moeyui1 <894immyk@gmail.com>
@moeyui1 moeyui1 requested review from sunjayBhatia and removed request for skriss November 21, 2022 04:06
@sunjayBhatia sunjayBhatia requested a review from skriss November 21, 2022 15:48
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2022
@sunjayBhatia sunjayBhatia removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2022
@sunjayBhatia sunjayBhatia merged commit e972f90 into projectcontour:main Dec 6, 2022
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] The "goboring-version" in "FIPS 140-2 in Contour" doc is outdated.
3 participants