Added support for ALL DNS lookup family
#4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishal-chdhry
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested changes
Dec 14, 2022
sunjayBhatia
added
release-note/small
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
all-dns
branch
from
b29ebe9 to
17795d9
Compare
|
@vishal-chdhry did a little cleanup on this branch so we can get this in lgtm! |
sunjayBhatia
approved these changes
Dec 21, 2022
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
|
@vishal-chdhry see this fix: d125ab0 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4909 +/- ##
==========================================
+ Coverage 76.47% 76.49% +0.01%
==========================================
Files 140 140
Lines 16750 16762 +12
==========================================
+ Hits 12810 12822 +12
Misses 3690 3690
Partials 250 250
|
|
cc @skriss in case you have anything on this |
skriss
approved these changes
Dec 21, 2022
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Vishal Choudhary <contactvishaltech@gmail.com> Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
ALLoption which when selected, the DNS resolver returns both IPv4 and IPv6 addresses (if they exist),Closes #4778
Signed-off-by: Vishal Choudhary contactvishaltech@gmail.com