Do not trigger DAG rebuild for irrelevant HTTProutes/TLSroutes #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skriss @sunjayBhatia Please help review |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4912 +/- ##
==========================================
+ Coverage 76.45% 76.47% +0.01%
==========================================
Files 140 140
Lines 16711 16724 +13
==========================================
+ Hits 12777 12790 +13
Misses 3684 3684
Partials 250 250
|
fangfpeng
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
skriss
changed the title
skriss
requested changes
Dec 14, 2022
|
Now that we've merged the |
skriss
added
the
release-note/small
|
Retargeted the PR to main and now needs a rebase. |
skriss
reviewed
Dec 15, 2022
For HTTProute/TLSRoute, only if it references the relevant Gateway, it will trigger DAG rebuild. Signed-off-by: fpeng <fpeng@vmware.com>
Do not insert irrelevant HTTPRoute/TLSRoute to cache. Make test changes due to this change. Also add postive test when removing HTTPRoute/TLSRoute. Signed-off-by: fpeng <fpeng@vmware.com>
Do not insert irrelevant HTTPRoute/TLSRoute to cache. Make test changes due to this change. Also add postive test when removing HTTPRoute/TLSRoute. Signed-off-by: fpeng <fpeng@vmware.com>
need to add route to the cache always so revert some of the previous changes. Updates projectcontour#4800 Signed-off-by: Fang Peng <fpeng@vmware.com>
fangfpeng
force-pushed
the
dev-gwapi-0.6-1208
branch
from
d37e63f to
c022b04
Compare
|
One last thing to address: please add a file |
Add change log and address review comment regarding to reducing nesting. Updates projectcontour#4800 Signed-off-by: Fang Peng <fpeng@vmware.com>
Updates projectcontour#4800 Signed-off-by: Fang Peng <fpeng@vmware.com>
skriss
approved these changes
Dec 16, 2022
sunjayBhatia
approved these changes
Dec 16, 2022
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…ctcontour#4912) For HTTProute/TLSRoute, only if it references the relevant Gateway, it will trigger DAG rebuild. Signed-off-by: Fang Peng <fpeng@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…ctcontour#4912) For HTTProute/TLSRoute, only if it references the relevant Gateway, it will trigger DAG rebuild. Signed-off-by: Fang Peng <fpeng@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
…ctcontour#4912) For HTTProute/TLSRoute, only if it references the relevant Gateway, it will trigger DAG rebuild. Signed-off-by: Fang Peng <fpeng@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For HTTProute/TLSRoute, only if it references the relevant Gateway, it will trigger DAG rebuild.
Closes #4800.
Signed-off-by: fpeng fpeng@vmware.com