-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move guides into versioned documentation #4977
Conversation
…in/guides Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
One thing I don't like is how long the nav/TOC is getting for docs, it just makes it hard to navigate. Would be nice to have the sections within the TOC be collapsible. ref. #3815 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4977 +/- ##
==========================================
- Coverage 77.61% 77.60% -0.01%
==========================================
Files 140 140
Lines 16871 16875 +4
==========================================
+ Hits 13094 13096 +2
- Misses 3520 3522 +2
Partials 257 257
|
Signed-off-by: Steve Kriss <krisss@vmware.com>
I think this is looking pretty good, marked ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the deploy preview looks great 👍🏽
looked through the commits as well, seems like you caught all the cross-page links
might be a good time to reenable or at least rerun the link checker for this change
Signed-off-by: Steve Kriss <krisss@vmware.com>
Yeah didn't that break with the migration to Hugo? Will have to look and see if there's something we can use, agreed it would be a nice check to have. |
yep i think that was around the time it was disabled |
I'm cool with merging and doing another link check on the side and fixing things in another PR! (if there is anything to fix) |
Sounds good, will merge and then find a link checker to use. |
Closes projectcontour#4396. Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
Closes projectcontour#4396. Signed-off-by: Steve Kriss <krisss@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
Closes projectcontour#4396. Signed-off-by: Steve Kriss <krisss@vmware.com>
Closes #4396.
Couple notes:
Still clicking around to make sure I didn't break anything.
Preview site: https://deploy-preview-4977--projectcontour.netlify.app/