internal/dag: Loosen restrictions on duplicate include detection #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty or lone prefix path matches on "/" are now not considered duplicates, due to complications with existing examples and possible wide range of users relying on the previous less restrictive behavior. Updates release note on duplicate include detection to major and adds some more detail Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
stevesloka and
skriss
and removed request for
a team
sunjayBhatia
commented
Jan 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5017 +/- ##
==========================================
+ Coverage 77.47% 77.49% +0.01%
==========================================
Files 138 138
Lines 16894 16904 +10
==========================================
+ Hits 13088 13099 +11
+ Misses 3551 3550 -1
Partials 255 255
|
skriss
reviewed
Jan 27, 2023
|
Yep, this looks sensible for now and we'll revisit more broadly with 1.25. (As we discussed, it's unlikely that there is much usage of duplicate non-default include conditions, because if they were adjacent in the list of includes they already would've been flagged as duplicates. They would've had to be separated by a non-duplicate include in the middle in order to get through. Just doesn't seem very likely. That's why we're not too concerned about behavior for that case changing) |
skriss
approved these changes
Jan 27, 2023
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…jectcontour#5017) Empty or lone prefix path matches on "/" are now not considered duplicates, due to complications with existing examples and possible wide range of users relying on the previous less restrictive behavior. Updates release note on duplicate include detection to major and adds some more detail Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…jectcontour#5017) Empty or lone prefix path matches on "/" are now not considered duplicates, due to complications with existing examples and possible wide range of users relying on the previous less restrictive behavior. Updates release note on duplicate include detection to major and adds some more detail Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
…jectcontour#5017) Empty or lone prefix path matches on "/" are now not considered duplicates, due to complications with existing examples and possible wide range of users relying on the previous less restrictive behavior. Updates release note on duplicate include detection to major and adds some more detail Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty or lone prefix path matches on "/" are now not considered duplicates, due to complications with existing examples and possible wide range of users relying on the previous less restrictive behavior.
Updates release note on duplicate include detection to major and adds some more detail