Improve e2e helper updateAndWaitFor to avoid conflicts #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will retry updates on conflict rather than failing immediately To fix failures like: https://github.com/projectcontour/contour/actions/runs/7460847887/job/20299759302 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
tsaarni,
skriss,
a team and
davinci26
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6069 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 138 138
Lines 19778 19778
=======================================
Hits 15589 15589
Misses 3886 3886
Partials 303 303 |
skriss
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will retry updates on conflict rather than failing immediately
To fix failures like: https://github.com/projectcontour/contour/actions/runs/7460847887/job/20299759302