release-1.28: Disable Envoy removing TE request header #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunjayBhatia
added
the
release-note/none-required
sunjayBhatia
requested review from
tsaarni,
skriss,
a team,
davinci26 and
izturn
and removed request for
a team
sunjayBhatia
force-pushed
the
1.28-disable-http2-transfer-encoding-removal
branch
3 times, most recently
from
9ecb769
to
e11b0a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #6290 +/- ##
=============================================
Coverage 79.51% 79.51%
=============================================
Files 142 142
Lines 16243 16244 +1
=============================================
+ Hits 12916 12917 +1
Misses 3014 3014
Partials 313 313
|
skriss
approved these changes
Mar 18, 2024
Removal of the header was added by default in Envoy v1.29.0. This change reverts back to prior behavior. This change can be reverted once envoyproxy/envoy#32255 is backported or present in a new release of Envoy. Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
force-pushed
the
1.28-disable-http2-transfer-encoding-removal
branch
from
7fcdd46
to
f43135e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the header was added by default in Envoy v1.29.0. This change reverts back to prior behavior.
This change can be reverted once envoyproxy/envoy#32255 is backported or present in a new release of Envoy.