Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate xDS server type field #6561

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

skriss
Copy link
Member

@skriss skriss commented Jul 17, 2024

Fields are planned to be removed in the 1.31 release.

Updates #2134.

Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss added the release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. label Jul 17, 2024
@skriss skriss requested a review from a team as a code owner July 17, 2024 17:18
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team July 17, 2024 17:18
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and clayton-gonsalves and removed request for a team July 17, 2024 17:18
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (260151f) to head (9461bbf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6561   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         133      133           
  Lines       15873    15873           
=======================================
  Hits        12959    12959           
  Misses       2620     2620           
  Partials      294      294           
Files Coverage Δ
cmd/contour/serve.go 22.66% <ø> (ø)
pkg/config/parameters.go 88.03% <ø> (ø)

@skriss skriss enabled auto-merge (squash) July 17, 2024 17:46
@skriss skriss merged commit 49ede7e into projectcontour:main Jul 17, 2024
26 checks passed
@skriss skriss deleted the pr-deprecate-xds-server-type branch July 17, 2024 19:16
geomacy pushed a commit to chaosbox/contour that referenced this pull request Aug 22, 2024
Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Geoff Macartney <geoff.macartney@sky.uk>
SamMHD pushed a commit to SamMHD/contour that referenced this pull request Sep 8, 2024
Fields are planned to be removed in the 1.31 release.

Updates projectcontour#2134.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants