Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displayed if the IP is part of a CDN in the output #308

Closed
JoshuaMart opened this issue May 7, 2022 · 2 comments · Fixed by #324
Closed

Displayed if the IP is part of a CDN in the output #308

JoshuaMart opened this issue May 7, 2022 · 2 comments · Fixed by #324
Assignees
@LuitelSamikshya
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
v2.0.8

Comments

@JoshuaMart
Copy link
Contributor

Hi Team,
I think it would be interesting in the JSON output to add a boolean to indicate if the IP is part of a CDN or not.
This would be useful for data parsing / data reuse purposes.

Like :

{"host":"domain.tld","ip":"104.16.99.52","port":443,"cdn":true,"timestamp":"2022-05-07T08:37:38.155294822Z"}

Regards
@JoshuaMart JoshuaMart added the Type: Enhancement Most issues will probably ask for additions or changes. label May 7, 2022
@ehsandeep
Copy link
Member

ehsandeep commented May 7, 2022 •
edited
Loading

@JoshuaMart this is something we expose with httpx, but can be done optionally with naabu as well.

echo version-check.nuclei.sh | httpx -json -cdn | jq .

  "cdn": true,
  "cdn-name": "cloudflare",

@ehsandeep ehsandeep added the Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix label May 7, 2022
@LuitelSamikshya LuitelSamikshya self-assigned this May 16, 2022
@LuitelSamikshya LuitelSamikshya linked a pull request May 17, 2022 that will close this issue
Issue 308 display ip part of cdn #324
Merged
@LuitelSamikshya LuitelSamikshya added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label May 18, 2022
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 19, 2022
@ehsandeep
Copy link
Member

@JoshuaMart, this is now supported in dev version, thanks again for the feature request.

@ehsandeep ehsandeep added this to the v2.0.8 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
v2.0.8
Development

Successfully merging a pull request may close this issue.

Issue 308 display ip part of cdn projectdiscovery/naabu
3 participants
@ehsandeep @JoshuaMart @LuitelSamikshya