Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 308 display ip part of cdn #324

Merged
merged 5 commits into from
May 19, 2022
Merged

Issue 308 display ip part of cdn #324

merged 5 commits into from
May 19, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented May 17, 2022 •
edited
Loading

This PR adds cdn flag and displays if the IP is part of a CDN in the output.

@LuitelSamikshya LuitelSamikshya marked this pull request as draft May 17, 2022 22:28
@LuitelSamikshya LuitelSamikshya self-assigned this May 17, 2022
@LuitelSamikshya LuitelSamikshya linked an issue May 17, 2022 that may be closed by this pull request
Displayed if the IP is part of a CDN in the output #308
Closed
@LuitelSamikshya LuitelSamikshya marked this pull request as ready for review May 18, 2022 15:43
@LuitelSamikshya LuitelSamikshya added Type: Enhancement Most issues will probably ask for additions or changes. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 18, 2022
@LuitelSamikshya LuitelSamikshya requested a review from Mzack9999 May 18, 2022 15:44
Mzack9999
Mzack9999 approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment •
edited by ehsandeep
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example

$ echo www.hackerone.com | go run . -p 80 -cdn -json | jq .

{
  "host": "www.hackerone.com",
  "ip": "104.16.100.52",
  "port": 80,
  "cdn": true,
  "cdn-name": "cloudflare",
  "timestamp": "2022-05-19T09:31:19.165675Z"
}

@Mzack9999 Mzack9999 requested a review from ehsandeep May 18, 2022 16:52
@ehsandeep ehsandeep merged commit abd8201 into dev May 19, 2022
@ehsandeep ehsandeep deleted the issue-308-display-ip-part-of-cdn branch May 19, 2022 09:33
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Displayed if the IP is part of a CDN in the output
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999