Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding source port support via source-ip #345

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Adding source port support via source-ip #345

merged 1 commit into from
Jun 9, 2022

Conversation

Mzack9999
Copy link
Member

Description

This PR adds support for source port via the existing source-ip parameter

Example

$ sudo go run . -source 192.168.1.2:15000

@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Enhancement Most issues will probably ask for additions or changes. labels Jun 5, 2022
@Mzack9999 Mzack9999 self-assigned this Jun 5, 2022
@Mzack9999 Mzack9999 linked an issue Jun 5, 2022 that may be closed by this pull request
Support for Source Port Manipulation #321
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2022
View reviewed changes
v2/pkg/scan/scan.go
@@ -517,7 +517,7 @@
}

tcp := layers.TCP{
SrcPort: layers.TCPPort(s.listenPort),
SrcPort: layers.TCPPort(s.SourcePort),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint16 without an upper bound check.
v2/pkg/scan/scan.go
@@ -575,7 +575,7 @@
}

tcp := layers.TCP{
SrcPort: layers.TCPPort(s.listenPort),
SrcPort: layers.TCPPort(s.SourcePort),

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint16 without an upper bound check.
@Mzack9999 Mzack9999 requested review from Ice3man543 and ehsandeep June 6, 2022 18:12
@ehsandeep ehsandeep merged commit 2adca43 into dev Jun 9, 2022
@ehsandeep ehsandeep deleted the issue-321-source-port branch June 9, 2022 15:14
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 9, 2022
@ehsandeep ehsandeep mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Source Port Manipulation
3 participants
@Mzack9999 @ehsandeep @Ice3man543