Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing wrong boolean check on verify condition #519

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Fixing wrong boolean check on verify condition #519

merged 2 commits into from
Jan 4, 2023

Conversation

MiracleLau
Copy link
Contributor

@MiracleLau MiracleLau commented Dec 29, 2022 •
edited by Mzack9999
Loading

Description

This PR fixes a wrong check with -verify flag what is incorrectly flagged as not supported in active scan mode

@Mzack9999 Mzack9999 linked an issue Jan 3, 2023 that may be closed by this pull request
Verify ports feature (-verify) not working #509
Closed
@Mzack9999 Mzack9999 self-requested a review January 3, 2023 08:39
@Mzack9999 Mzack9999 changed the title fix issue #509 Fixing wrong boolean check on verify condition Jan 4, 2023
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 4, 2023
Mzack9999
Mzack9999 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Mzack9999 Mzack9999 merged commit cc4cedb into projectdiscovery:dev Jan 4, 2023
@MiracleLau MiracleLau deleted the fix-issue-509 branch January 4, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify ports feature (-verify) not working
2 participants
@MiracleLau @Mzack9999