Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gotify support #269

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Gotify support #269

merged 6 commits into from
Aug 16, 2023

Conversation

bugrakocabay
Copy link
Contributor

@bugrakocabay bugrakocabay commented Jun 9, 2023 •
edited
Loading

Added support for Gotify.

Example provider config info;

gotify:
  - id: 'gotify'
    gotify_host: 'XXXXXXX'
    gotify_port: 'XXXXXXX'
    gotify_token: 'XXXXXXX'
    gotify_format: '{{data}}'

@bugrakocabay bugrakocabay changed the title Gotify Gotify support Jun 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bugrakocabay
Copy link
Contributor Author

closes #268

@ehsandeep ehsandeep linked an issue Jun 13, 2023 that may be closed by this pull request
Feature: Gotify support #268
Closed
@bugrakocabay
Copy link
Contributor Author

@ehsandeep review please

@ehsandeep ehsandeep added the Type: Enhancement Most issues will probably ask for additions or changes. label Jul 8, 2023
@ehsandeep ehsandeep requested a review from tarunKoyalwar July 8, 2023 22:25
tarunKoyalwar
tarunKoyalwar approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@bugrakocabay thanks for PR and sorry it took a while to review this , i have added 2 more options to disabletls and change title of notification messages

$ cat << EOF | ./notify -pc pc.yaml -p gotify -v
Gotify support added in Notify!!!!
EOF

             __  _ ___    
  ___  ___  / /_(_) _/_ __
 / _ \/ _ \/ __/ / _/ // /
/_//_/\___/\__/_/_/ \_, / v1.0.5
                   /___/  

		projectdiscovery.io

[INF] Current notify version 1.0.5 (latest)
Gotify support added in Notify!!!!
[VER] gotify notification sent for id: gotify

Screenshot 2023-07-13 at 8 53 37 PM

@tarunKoyalwar tarunKoyalwar requested a review from ehsandeep July 13, 2023 15:31
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ehsandeep ehsandeep merged commit 447e505 into projectdiscovery:dev Aug 16, 2023
@timsutton timsutton mentioned this pull request Feb 10, 2024
Merged
@fopina-ci fopina-ci mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Gotify support
3 participants
@bugrakocabay @ehsandeep @tarunKoyalwar