Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unlocking unlocked mutex in GlobalRestoreBytesBufferAlloc #5715

Closed
1 task done
yaron12n opened this issue Oct 10, 2024 · 2 comments · Fixed by #5714
Closed
1 task done

[BUG] Unlocking unlocked mutex in GlobalRestoreBytesBufferAlloc #5715

yaron12n opened this issue Oct 10, 2024 · 2 comments · Fixed by #5714
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
nuclei v3.3.5

Comments

@yaron12n
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Current Behavior

Hey! I'm getting a panic in GlobalRestoreBytesBufferAlloc:

/go/pkg/mod/github.com/projectdiscovery/nuclei/v3@v3.3.2/pkg/protocols/common/protocolstate/memguardian.go:109
github.com/projectdiscovery/nuclei/v3/pkg/protocols/common/protocolstate.GlobalRestoreBytesBufferAlloc()
/usr/local/go/src/sync/mutex.go:225
/usr/local/go/src/sync/mutex.go:231 +0x38
sync.(*Mutex).unlockSlow(0xa943200, 0xffffffff)

It was probably caused by trying to unlock an unlocked mutex.

Expected Behavior

Probably race should be fixed for unlocking the mutex

Steps To Reproduce

Happen statistically, couldn't reproduce

Relevant log output

No response

Environment

  • OS: Debian latest
  • Nuclei: v3.3.2

Anything else?

No response
@yaron12n yaron12n added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 10, 2024
@ehsandeep ehsandeep linked a pull request Oct 10, 2024 that will close this issue
Unlock memguard global change mutex only when locked #5714
Merged
2 tasks
@yaron12n
Copy link
Author

yaron12n commented Oct 14, 2024 •
edited
Loading

Can you please release this fixed version? 🙏 @ehsandeep

@ehsandeep ehsandeep added this to the nuclei v3.3.5 milestone Oct 14, 2024
@ehsandeep
Copy link
Member

@yaron12n https://github.com/projectdiscovery/nuclei/releases/tag/v3.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
nuclei v3.3.5
Development

Successfully merging a pull request may close this issue.

Unlock memguard global change mutex only when locked dany74q/nuclei
2 participants
@ehsandeep @yaron12n