Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock memguard global change mutex only when locked #5714

Conversation

dany74q
Copy link
Contributor

@dany74q dany74q commented Oct 10, 2024

  • Unlock the memguard global change mutex only when locked, otherwise could panic on concurrent operations

Proposed changes

Unlock the memgoard global change mutex only when locked.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes

- Unlock the memguard global change mutex only when locked, otherwise could panic on concurrent operations
@ehsandeep ehsandeep linked an issue Oct 10, 2024 that may be closed by this pull request
1 task
@GeorginaReeder
Copy link

Thanks for your contribution @dany74q !

Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice catch!

@ehsandeep ehsandeep merged commit 888a732 into projectdiscovery:dev Oct 14, 2024
8 of 12 checks passed
@dany74q dany74q deleted the danny/unlock-memguard-global-change-mutex-only-when-locked branch October 14, 2024 10:54
@ehsandeep ehsandeep added this to the nuclei v3.3.5 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unlocking unlocked mutex in GlobalRestoreBytesBufferAlloc
5 participants