Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix removing semicolon from raw request #3650

Merged
merged 2 commits into from
May 5, 2023
Merged

fix removing semicolon from raw request #3650

merged 2 commits into from
May 5, 2023

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented May 5, 2023 •
edited
Loading

Proposed changes

#3574 Semicolon in GET requests Removed

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M linked an issue May 5, 2023 that may be closed by this pull request
Semicolon in GET requests Removed #3574
Closed
@RamanaReddy0M RamanaReddy0M self-assigned this May 5, 2023
@RamanaReddy0M
Copy link
Contributor Author

upstream pr: projectdiscovery/utils#145

tarunKoyalwar
tarunKoyalwar approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

depends on projectdiscovery/utils#145

@ehsandeep ehsandeep merged commit 11b5841 into dev May 5, 2023
@ehsandeep ehsandeep deleted the issue-3574-semicolon-removed branch May 5, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semicolon in GET requests Removed
3 participants
@RamanaReddy0M @ehsandeep @tarunKoyalwar