Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(vardump): use godump lib #5676

Merged
merged 6 commits into from
Oct 14, 2024
Merged

refactor(vardump): use godump lib #5676

merged 6 commits into from
Oct 14, 2024

Conversation

dwisiswant0
Copy link
Member

Proposed changes

  • Refactor vardump to use the godump pkg
  • Introduce a global Limit variable in the vardump
  • Add the VarDumpLimit (-var-dump-limit/-vdl) option

Closes #5662 #5675

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dwisiswant0
refactor(vardump): use godump lib
096da1b 
also increate limit char to `255`.

Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
feat(vardump): add global var Limit
2fdfb78 
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
chore(protocols): rm newline
ab57ae1 
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
feat(types): add VarDumpLimit option
d04c788 
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
test(vardump): add test cases
726f43b 
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
chore: tidy up mod
0b27af7 
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0 dwisiswant0 linked an issue Sep 30, 2024 that may be closed by this pull request
[FEATURE] Add -var-dump-limit flag for customizable char limit in place of -show-var-dump #5675
Closed
@ehsandeep ehsandeep merged commit 2c832f5 into dev Oct 14, 2024
11 of 12 checks passed
@ehsandeep ehsandeep deleted the dwisiswant0/refactor/vardump/use-godump-to-dumps branch October 14, 2024 14:01
@BrewTestBot BrewTestBot mentioned this pull request Oct 19, 2024
Merged
@blsaccess blsaccess mentioned this pull request Oct 20, 2024
Merged
@KGorbakon KGorbakon mentioned this pull request Oct 28, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

@dogancanbakir dogancanbakir Awaiting requested review from dogancanbakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dwisiswant0 @ehsandeep @Ice3man543