feat(templates): rm string conversion

[dwisiswant0]

Proposed changes

Fix #6010

Checklist

• Pull request is created against the dev branch
• All checks passed (lint, unit/integration/regression tests etc.) with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Summary by CodeRabbit

• Bug Fixes
  • Adjusted tag filtering parameter processing to preserve original case for template fields.

Note: The changes are subtle and primarily relate to internal parameter handling without affecting the core functionality of tag filtering.

[coderabbitai]

Walkthrough

The pull request modifies the tryCollectConditionsMatchinfo function in the pkg/templates/tag_filter.go file. The key change involves removing the lowercase conversion for ID, Name, and Description fields when creating the parameters map. This means these fields will now be assigned to the map in their original case, potentially affecting how template filtering works, especially for case-sensitive comparisons like CVE identifiers.

Changes

File	Change Summary
pkg/templates/tag_filter.go	Removed lowercase conversion for ID, Name, and Description fields in tryCollectConditionsMatchinfo function

Assessment against linked issues

Objective	Addressed	Explanation
Fix -tc not working with CVE ids [#6010]	✅

Suggested reviewers

• dogancanbakir
• ehsandeep

Poem

🐰 A rabbit's tale of code so bright,
Case matters now, with all its might!
No more lowercase, pure and true,
CVE ids dance in their hue,
Filtering templates with delight! 🔍

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58ae87c and 7a41c3a.

📒 Files selected for processing (1)

• pkg/templates/tag_filter.go (1 hunks)

🔇 Additional comments (3)

pkg/templates/tag_filter.go (3)

199-201: 🛠️ Refactor suggestion

Consider a comprehensive string handling strategy.

The removal of string conversion here appears to be part of a larger effort. Given the TODO comment at line 449 about string handling normalization, consider:

1. Implementing the suggested StringSlice type for consistent handling.
2. Standardizing case-sensitivity rules across the codebase.
3. Adding test cases for case-sensitive and case-insensitive scenarios.

Here's a suggested approach:

// Add a new type for consistent string handling
+type StringSlice []string
+
+func (s StringSlice) Contains(value string) bool {
+    // Implement case-sensitive or case-insensitive comparison based on config
+    for _, v := range s {
+        if v == value { // or strings.EqualFold(v, value) for case-insensitive
+            return true
+        }
+    }
+    return false
+}

// Use the new type in the parameters map
-        "id":          template.ID,
-        "name":        template.Info.Name,
-        "description": template.Info.Description,
+        "id":          StringSlice{template.ID},
+        "name":        StringSlice{template.Info.Name},
+        "description": StringSlice{template.Info.Description},

Likely invalid or redundant comment.

---

199-201: ⚠️ Potential issue

Potential case-sensitivity mismatch in template filtering.

The removal of string conversion for ID, Name, and Description fields in the parameters map could lead to inconsistencies with the rest of the codebase, particularly:

1. The Match function still uses strings.ToLower(template.ID) for ID matching (line 143), but the parameters map now stores the original case.
2. This could cause template filtering to behave differently when using conditions vs. direct ID matching.

Let's verify the potential impact:

---

199-201: Document the case-sensitivity change.

This change introduces case-sensitive matching for template fields in conditions, which is a breaking change that needs to be documented:

1. Update the documentation to clarify the case-sensitive behavior.
2. Consider adding a migration guide for template authors.

Let's check the documentation:

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.