Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated masutil + add error on dsl evaluate error #127

Merged
merged 1 commit into from
May 31, 2022

Conversation

Ice3man543
Copy link
Member

Proposed changes

Closes #116 by adding request and response objects to mapsutil functions + added error logging in case of DSL evaluation for catching such errors in future.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue May 31, 2022 that may be closed by this pull request
@Ice3man543 Ice3man543 self-assigned this May 31, 2022
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label May 31, 2022
@ehsandeep ehsandeep merged commit f41c9a1 into dev May 31, 2022
@ehsandeep ehsandeep deleted the dsl-evaluate-error-fix branch May 31, 2022 14:12
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match DSL functionality doesn't work
3 participants