Improved json output

[vzamanillo]

Implement #245

[ehsandeep]

Hi @vzamanillo,

Thank you for the PR and working on this, I see this PR adds sources Information in JSON output which is really useful, apart from that, I also noticed somehow this breaks nW flag.

./subfinder -d hackerone.com -oJ -nW -o test.txt

This doesn't add host information in the JSON output like the previous version, ignore this comment if you still working on this PR for other issues listed in #245

[vzamanillo]

Hey, don't worry I will take a look to solve it, maybe I am missing something.

[vzamanillo]

Sorry, I am a little bit confused with the actual behaviour

// Write the output to the file depending upon user requirement
if r.options.HostIP {
  err = WriteHostIPOutput(foundResults, file)
} else if r.options.JSON {
  err = WriteJSONOutput(foundResults, file)
} else {
  if r.options.RemoveWildcard {
    err = WriteHostOutputNoWildcard(foundResults, file)
  } else {
    err = WriteHostOutput(uniqueMap, file)
  }
}

• if r.options.HostIP writes Host + IP in plain text (no JSON):

sb.WriteString(host)
sb.WriteString(",")
sb.WriteString(ip)
sb.WriteString("\n")

• else if r.options.JSON writes Host + IP in JSON:

data.Host = host
data.IP = ip
err := encoder.Encode(&data)

• else if r.options.RemoveWildcard writes Host only in plain text (no JSON)

sb.WriteString(host)
sb.WriteString("\n")

• else writes Host only in plain text (no JSON)

My approach

• If you ask for HostIP writes Host + IP (JSON / Plain text)
• If you ask for RemoveWildcard writes Host only (JSON / Plain text)
• Else writes Host (JSON / Plain text)

Why the existing master branch writes Host + IP in all cases if -oJ is specified even if the user don't ask for IP?

[Ice3man543]

@vzamanillo so, regarding your question, the behaviour is as follows -

1. If user asks for Host as well as IP, write the host->IP in plain text. (Expects nW flag is provided)
2. If user asks for JSON, write host->IP in json format. (Expects nW flag is provided)
3. Else, if user asks for removing wildcards, write only hosts that are not wildcard to plain text file. Otherwise, write normal output (only hosts) to file.

[vzamanillo]

I think this is ready to merge.

This is the final behaviour:

• You can always ask for JSON output (-oJ), it is fully compatible with all options.
• You can set an absolute path for output (-o) file on single domain enumeration (intermediate dirs are created).
• If you ask for HostIP (-oI) writes Host + IP (JSON / Plain text)
• If you ask for RemoveWildcard (-nW) writes Host only (JSON / Plain text)
• Else writes Host (JSON / Plain text)

Check it and tell me impressions / improvements / flaws.

[Ice3man543]

This looks good to me. Merging now! Great work as always.