fix warnings

projecteru2 · May 15, 2023 · 28d74ad · 28d74ad
1 parent 86f7f62
commit 28d74ad
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/logs/writer.go b/logs/writer.go
@@ -37,7 +37,7 @@ type discard struct {
 }
 
 // Write writer
-func (d discard) Write(p []byte) (n int, err error) {
+func (d discard) Write([]byte) (n int, err error) {
 	return 0, nil
 }
 

diff --git a/runtime/docker/docker.go b/runtime/docker/docker.go
@@ -131,9 +131,9 @@ func (d *Docker) AttachWorkload(ctx context.Context, ID string) (io.Reader, io.R
 		return nil, nil, err
 	}
 
-	cap, _ := units.RAMInBytes("10M")
-	outr, outw := utils.NewBufPipe(cap)
-	errr, errw := utils.NewBufPipe(cap)
+	capacity, _ := units.RAMInBytes("10M")
+	outr, outw := utils.NewBufPipe(capacity)
+	errr, errw := utils.NewBufPipe(capacity)
 
 	_ = utils.Pool.Submit(func() {
 		defer func() {

diff --git a/runtime/docker/stat_notlinux.go b/runtime/docker/stat_notlinux.go
@@ -11,7 +11,7 @@ import (
 	"github.com/shirou/gopsutil/net"
 )
 
-func getStats(ctx context.Context, ID string, pid int, proc string) (*docker.CgroupCPUStat, cpu.TimesStat, []net.IOCountersStat, error) {
+func getStats(ctx context.Context, _ string, _ int, _ string) (*docker.CgroupCPUStat, cpu.TimesStat, []net.IOCountersStat, error) {
 	containerCPUStats := &docker.CgroupCPUStat{
 		TimesStat: cpu.TimesStat{},
 		Usage:     0.0,
@@ -26,6 +26,6 @@ func getStats(ctx context.Context, ID string, pid int, proc string) (*docker.Cgr
 	return containerCPUStats, systemCPUStats, []net.IOCountersStat{}, nil
 }
 
-func getMemStats(ctx context.Context, ID string) (*docker.CgroupMemStat, error) {
+func getMemStats(context.Context, string) (*docker.CgroupMemStat, error) {
 	return &docker.CgroupMemStat{}, nil
 }
diff --git a/runtime/yavirt/yavirt.go b/runtime/yavirt/yavirt.go
@@ -112,12 +112,12 @@ func (y *Yavirt) detectWorkload(ctx context.Context, ID string) (*Guest, error)
 }
 
 // AttachWorkload not implemented yet
-func (y *Yavirt) AttachWorkload(ctx context.Context, ID string) (io.Reader, io.Reader, error) {
+func (y *Yavirt) AttachWorkload(context.Context, string) (io.Reader, io.Reader, error) {
 	return nil, nil, common.ErrNotImplemented
 }
 
 // CollectWorkloadMetrics no need yet
-func (y *Yavirt) CollectWorkloadMetrics(ctx context.Context, ID string) {}
+func (y *Yavirt) CollectWorkloadMetrics(context.Context, string) {}
 
 // ListWorkloadIDs lists workload IDs filtered by given condition
 func (y *Yavirt) ListWorkloadIDs(ctx context.Context, filters map[string]string) (ids []string, err error) {
@@ -199,12 +199,12 @@ func (y *Yavirt) GetStatus(ctx context.Context, ID string, checkHealth bool) (*t
 }
 
 // GetWorkloadName not implemented yet
-func (y *Yavirt) GetWorkloadName(ctx context.Context, ID string) (string, error) {
+func (y *Yavirt) GetWorkloadName(context.Context, string) (string, error) {
 	return "", common.ErrNotImplemented
 }
 
 // LogFieldsExtra .
-func (y *Yavirt) LogFieldsExtra(ctx context.Context, ID string) (map[string]string, error) {
+func (y *Yavirt) LogFieldsExtra(context.Context, string) (map[string]string, error) {
 	return map[string]string{}, nil
 }
 

diff --git a/utils/retry.go b/utils/retry.go
@@ -60,7 +60,7 @@ func (r *RetryTask) Run(ctx context.Context) error {
 }
 
 // Stop stops running task
-func (r *RetryTask) Stop(ctx context.Context) {
+func (r *RetryTask) Stop(context.Context) {
 	r.cancel()
 }
 

diff --git a/utils/udev_notlinux.go b/utils/udev_notlinux.go
@@ -3,6 +3,6 @@
 
 package utils
 
-func GetDevicePath(major, minor uint64) (devPath string, err error) {
+func GetDevicePath(uint64, uint64) (devPath string, err error) {
 	return "/dev/random", nil
 }