fix the issue of building docker image #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2022
jschwinger233
approved these changes
Jan 12, 2022
|
那个 hotfix-1 可以手动 eru-cli build 一个正确的版本 |
DuodenumL
added a commit
to DuodenumL/core
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
发现在非master的分支上打tag的时候，自动构建的docker image是基于触发时最新的master版本构建的，而非触发构建的那个commit。这会导致用docker部署hotfix版本的时候，以为hotfix只是基于过去某个tag做了一点点小改动，实际上部署的是当前最新的版本，可能会包含未经测试的功能，从而有神秘的隐患。
这个PR修了一下这个问题。agent / cli也有同样的问题。