Custom functions with scope access #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to temporary solve complex translation cases mentioned in:
#268
projectfluent/fluent#80
Support user implemented custom functions that can access current scope, can work as Message references.
In future we could allow access in custom functions to additional information about current scope (developer arguments, local arguments, current errors)
Message references are highly needed for more complex translation cases with a lot of possible message combinations.
Additionally allow using expressions inside named arguments.
(It looks like by default fluent doesn't allow it Playground )
This functionality can be placed under boolean flag if we do not want to enable it by default.
See examples included in added tests.
Would like to get feedback if these changes can be upstreamed to fluent-rs.