End junk on blank lines to produce smaller Junk entries #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before we go ahead, I'd prefer to think and test how adjacent Junk entries with their line endings touch cross channel. I don't like the idea of holding back zeroseven for that. |
|
OK, let's keep this on hold for now. I'll port this to Python when |
|
Can you explain this once more? In projectfluent/fluent#211, we moved the spec to what the tooling parsers do. Is this still open? |
|
Yes, this can be closed now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #248.
This actually parses
Junkbetter than the spec says. I filed projectfluent/fluent#184 and projectfluent/fluent#185 to fix the reference parser.I'd like to land this as part of the Syntax 0.7 implementation.