-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe rename private messages? #85
Comments
How about vocabulary terms? We'd then have messages with public attributes and vocabulary terms with private messages. |
I find vocabulary as confusing as glossary for these messages:
Also, calling one attribute and the other message is not helping. They're both messages, because they're defined the same way. Maybe internal messages with private attributes? In the end, I believe any definition we come up with will need an explanation, and won't be intuitive. |
That's not what I meant; I must have not expressed it clearly. Let me try again: # This is a vocabulary term with an attribute. The attribute is private.
-brand-name = Firefox
.gender = masculine
# This is a message with an attribute. The attribute is public.
about-app = About { -brand-name }
.title = About this application |
My point is that |
Or maybe simply terms would work? You'd define terms which can be used in messages. |
We could also consider calling the expressions although we already use this word in a very specific meaning to describe contents of placeables which evaluate to something. |
That would make sense to me: With the note that, while we could give guidelines on how to use them, we can't really stop people from using an entire sentence. |
Right. Which is also why I suggested terms rather than words for example. Just in case :) |
I would like to reach an agreement on this today and make this part of the Syntax 0.5 spec. |
I've read up on access specifiers to get some 3rd party definitions of private. I don't think that the term (pun) is missing the point, the private messages are only accessible from within the MessageContext, but not outside of it. I don't think that they're treatment in static analysis (compare-locales) should impact that. So I think that we should continue to use the word private to describe the concept. protected might be a tad closer, but that's also an order of magnitude more technical, so I'd rather not go fo r that. That said.
What a mouthful. That's why I think Term is actually a good idea.
Sounds easier to me. |
Great points, @Pike, thanks! I'll prepare a PR. |
We've seen some confusion about how to talk about private messages and their attributes. The message itself is not really private -- tools will still check if it exists. What's private is its interface: the value and any attributes.
Perhaps we could find a better wording to make this easier to understand? in #62 I originally proposed glossary messages; the feedback was that in the world of localization glossaries already have a defined meaning and it's better not to confuse people further.
The text was updated successfully, but these errors were encountered: