Remove support for CR #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to take your offer to handle the CR-removal and the newline-normalization in two different issues. The CR one is pretty simple, the line ending died long before we introduced fluent. There's maybe a tad of "I can use my old java properties files, 'cause they work", but really, no. The newline normalization is something that deserves a deeper look, and maybe also a bit more external input. That seems like something in scope of an RFC. |
|
Sounds good! |
|
I removed the second commit from this PR and I'll file an RFC on Monday. |
Pike
approved these changes
Aug 3, 2018
stasm
changed the title
Pike
approved these changes
Aug 3, 2018
|
I filed #163 to discuss the normalization of EOLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #154.
The second commit normalizes the parsing of all supported line endings toMoved to #163.LF. We already useLFto represent blank lines in multiline patterns. Normalizing line endings in the parsed results removes surprises and ensures consistency across platforms. Serializers can implement an option to serialize usingCRLFif so desired.