-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few small fixes #749
Merged
matthijskooijman
merged 10 commits into
projecthamster:master
from
matthijskooijman:small-fixes
Dec 27, 2023
Merged
A few small fixes #749
matthijskooijman
merged 10 commits into
projecthamster:master
from
matthijskooijman:small-fixes
Dec 27, 2023
Commits on Nov 27, 2023
-
waf: Replace subprocess text argument to fix python3.6 compatibility
The python docs say: > New in version 3.7: text was added as a more readable alias for universal_newlines. So the code introduced in commit 99cef05 (Remove duplicated version detection code from waf/wscript) broke installs on python 3.6. This is fixed by passing an explicit encoding, which also has the effect of opening the pipe in text mode. This could have changed to universal_newlines instead, but that name seems a bit confusing and does not indicate that the result will be decoded into a string instead of returning bytes, so using encoding seems better.
Configuration menu - View commit details
-
Copy full SHA for c01d922 - Browse repository at this point
Copy the full SHA c01d922View commit details -
Strip whitespace from autodetected versions
This is mostly needed for the `VERSION` file, which could contain a trailing newline (e.g. vim always adds one unless you take effort to prevent that). For good measure, the git describe output also has whitespace stripped.
Configuration menu - View commit details
-
Copy full SHA for 5676f39 - Browse repository at this point
Copy the full SHA 5676f39View commit details -
waf: Remove unused variables from defs.py
Only DATA_DIR and VERSION are actually used. Removing LIB_DIR helps to make reproducible packages (presumably because then there is no reference to the build machine architecture in the resulting installed files, producing the same package regardless of build machine), see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028310 For consistency, just remove the other unused variables too.
Configuration menu - View commit details
-
Copy full SHA for bcbfaee - Browse repository at this point
Copy the full SHA bcbfaeeView commit details -
Drop check for ancient dbus versions
This check warned against using a very old dbus version that caused breakage. However, the check used the `distutils` package for version comparison, but that package is deprecated and will be removed in an upcoming python version. Since there does not seem to be a direct alternative for version comparisons in the core Python libraries and this check is about a 4-year old dbus version anyway, just remove the check rather than adding an extra dependency just for this.
Configuration menu - View commit details
-
Copy full SHA for f14e427 - Browse repository at this point
Copy the full SHA f14e427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22ddc68 - Browse repository at this point
Copy the full SHA 22ddc68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34787d9 - Browse repository at this point
Copy the full SHA 34787d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c72e094 - Browse repository at this point
Copy the full SHA c72e094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0819b45 - Browse repository at this point
Copy the full SHA 0819b45View commit details
Commits on Dec 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e766df4 - Browse repository at this point
Copy the full SHA e766df4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 685dc5f - Browse repository at this point
Copy the full SHA 685dc5fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.