Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small fixes #749

Merged
merged 10 commits into from
Dec 27, 2023
Merged

Commits on Nov 27, 2023

  1. waf: Replace subprocess text argument to fix python3.6 compatibility

    The python docs say:
    
    > New in version 3.7: text was added as a more readable alias for universal_newlines.
    
    So the code introduced in commit 99cef05 (Remove duplicated version
    detection code from waf/wscript) broke installs on python 3.6.
    
    This is fixed by passing an explicit encoding, which also has the effect
    of opening the pipe in text mode. This could have changed to
    universal_newlines instead, but that name seems a bit confusing and does
    not indicate that the result will be decoded into a string instead of
    returning bytes, so using encoding seems better.
    matthijskooijman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    c01d922 View commit details
    Browse the repository at this point in the history
  2. Strip whitespace from autodetected versions

    This is mostly needed for the `VERSION` file, which could contain
    a trailing newline (e.g. vim always adds one unless you take effort to
    prevent that). For good measure, the git describe output also has
    whitespace stripped.
    matthijskooijman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5676f39 View commit details
    Browse the repository at this point in the history
  3. waf: Remove unused variables from defs.py

    Only DATA_DIR and VERSION are actually used.
    
    Removing LIB_DIR helps to make reproducible packages (presumably because
    then there is no reference to the build machine architecture in the
    resulting installed files, producing the same package regardless of
    build machine), see
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028310
    
    For consistency, just remove the other unused variables too.
    matthijskooijman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    bcbfaee View commit details
    Browse the repository at this point in the history
  4. Drop check for ancient dbus versions

    This check warned against using a very old dbus version that caused
    breakage. However, the check used the `distutils` package for version
    comparison, but that package is deprecated and will be removed in an
    upcoming python version. Since there does not seem to be a direct
    alternative for version comparisons in the core Python libraries and
    this check is about a 4-year old dbus version anyway, just remove the
    check rather than adding an extra dependency just for this.
    matthijskooijman committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f14e427 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    22ddc68 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    34787d9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c72e094 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0819b45 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Configuration menu
    Copy the full SHA
    e766df4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    685dc5f View commit details
    Browse the repository at this point in the history