Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate geojupyterviz and update intro tutorial #255

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

wang-boyu
Copy link
Member

  • add deprecation warning to GeoJupyterViz
  • update intro tutorial to use Mesa's Solaraviz and Mesa-Geo's make_geospace_leaflet
  • format intro tutorial using black

@wang-boyu wang-boyu added docs Release notes label maintenance Release notes label labels Oct 10, 2024
@wang-boyu wang-boyu requested review from rht, EwoutH and tpike3 October 10, 2024 23:30
@wang-boyu wang-boyu force-pushed the deprecate-geojupyterviz branch from 32c7805 to 24cb92d Compare October 10, 2024 23:36
@wang-boyu wang-boyu force-pushed the deprecate-geojupyterviz branch from 24cb92d to d95d1ad Compare October 10, 2024 23:38
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (ce501b6) to head (d95d1ad).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   78.21%   73.54%   -4.67%     
==========================================
  Files          10       10              
  Lines         693      858     +165     
  Branches      151      132      -19     
==========================================
+ Hits          542      631      +89     
- Misses        127      194      +67     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with deprecating the old viz, and thanks for updating the tutorial. Bit difficult to review due tot all the whitespace changes, but is looks good.

Really appreciated!

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpike3 tpike3 merged commit 814d970 into projectmesa:main Oct 12, 2024
12 of 15 checks passed
@wang-boyu wang-boyu deleted the deprecate-geojupyterviz branch October 12, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Release notes label maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants