Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove race condition when pause button sometimes doesn't work #1745

Merged
merged 1 commit into from
Jul 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mesa/experimental/jupyter_viz.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ def make_model():

def on_value_play(change):
if viz.model.running:
playing.value = True
viz.do_step()
else:
playing.value = False
Expand All @@ -183,7 +182,7 @@ def on_value_play(change):
show_repeat=False,
on_value=on_value_play,
playing=playing.value,
on_play=playing.set,
on_playing=playing.set,
)
# threaded_do_play is not used for now because it
# doesn't work in Google colab. We use
Expand Down