Add pull request templates #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GitHub pull request templates for bug fixes and feature additions to help new contributors format their PRs and help maintainers to review these. The PR templates where modelled on the large PRs that were merged into Mesa recently. See https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
|
I like these as templates, but indeed it should not become a straightjacket. |
tpike3
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitHub pull request templates for bug fixes and feature additions to help new contributors format their PRs and help maintainers to review these.
The PR templates where modelled on the large PRs that were merged into Mesa recently.
In general, I don't like pushing things too hard into a mold, since each PR is different and might benefit from a different structure, but I feel these two are a good starting point, especially for new contributors.
See the docs Creating a pull request template for your repository for more information.